Conversation
The Delete log and Copy log buttons in the workspace details log list
spread the Tooltip.Trigger `{...props}` after their own `onclick`, so
the tooltip's handler overrode the button's, making clicks do nothing.
Spread `{...props}` before `onclick` to match the working pattern used
elsewhere on the page.
✅ Deploy Preview for devsydev canceled.
|
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for images-devsy-sh canceled.
|
skevetter
marked this pull request as ready for review
July 8, 2026 14:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Delete log button on the workspace details page did nothing when clicked. The Delete log and Copy log buttons are wrapped in a `Tooltip.Trigger` snippet that passes a `props` object containing bits-ui's own event handlers. Both buttons spread `{...props}` after their own `onclick`, so the tooltip's handler overrode the button's and the click was a no-op.
Reordered so `{...props}` is spread before `onclick`, matching the working pattern already used by the "copy output" button on the same page.
Summary by CodeRabbit